Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input.value attr for RequiredClaimName/Value (#20946) #21001

Conversation

jolheiser
Copy link
Member

credits to @soumyadey

Backport #20946

Values set for RequiredClaimName and RequiredClaimValue do not show up on UI.
Fix typo `values` to `value`.
@jolheiser jolheiser added this to the 1.17.2 milestone Aug 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 30, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2022
@jolheiser
Copy link
Member Author

🎺 🤖

@jolheiser jolheiser merged commit 54c0fe6 into go-gitea:release/v1.17 Aug 31, 2022
@jolheiser jolheiser deleted the backport-a2db81063be90499c16cbe1af777ee8858aa192d branch August 31, 2022 14:57
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants