Remove broken and useless file in build

[wolfogre]

Related to #17684, #18633.

After the changing of codeformat.FormatGoImports, the gitea-format-imports.go became uncompilable.

And According to the comment:

gitea/build/code-batch-process.go

Line 26 in 00d8d4a

// We also introduce a `gitea-fmt` command, it does better import formatting than gofmt/goimports

I think it would be clearer to rename gitea-format-imports.go to gitea-fmt.go

[wxiaoguang]

+1.

FYI, that's a historical reason of the name "code-batch-process.go".

At that time, Windows developers can not run make fmt because Windows can not accept long argument strings, the command ./program arg1 arg2 ... a-lot-of-args always fails on Windows. That's why code-batch-process.go comes, it splits the command line arguments into groups and run separate commands with fewer arguments: ./program arg1 arg2 ... argN and ./program argN+1 argN+2 ... argN+N, and so on.

After many code changes, Gitea has dropped many old tools, and I think most modern tools do not need to use ./program arg1 arg2 ... a-lot-of-args to pass filenames and won't have the annoying Windows command argument problem.

If it's the case, maybe it's time to retire the argument splitting function of code-batch-process.go

[wolfogre]

@wxiaoguang You may may have misunderstood me, I mean rename gitea-format-imports.go to gitea-fmt.go.

[wxiaoguang]

Hmm, I saw code-batch-process.go in the PR comment so added more information about it (at the beginning, they are related ...), and maybe other improvements can be done in the future. (I hidden the previous comment as off-topic)

[wxiaoguang]

Although the change L-G-T-M, I am not sure the gitea-fmt is really a good name for it, since it only handles imports now.

ps: there is also gitea-vet (https://gitea.com/gitea/gitea-vet) 😁 maybe it's time to improve some toolchains for Gitea together.

Since I have no preference and have no objection, I will put my L-G-T-M here.

​

[wolfogre]

Or we just remove the broken gitea-format-imports.go? It is not used by Makefile, and the command gitea-fmt could be replaced by gitea-vet.

[wxiaoguang]

Or we just remove the broken gitea-format-imports.go? It is not used by Makefile, and the command gitea-fmt could be replaced by gitea-vet.

Agree, removing gitea-format-imports.go seems a clear solution. And in the future, gitea-vet could take more works (if most developers agree)

[wolfogre]

Changed the commits, just removed the broken file and the outdated introduction which confused me 😂

[wxiaoguang]

Changed the commits, just removed the broken file and the outdated introduction which confused me 😂

Actually, the comment is correct (but not clear ....)

gitea/build/code-batch-process.go

Lines 267 to 273 in a2db810

	switch subCmd {
	case "gitea-fmt":
	if containsString(subArgs, "-d") {
	log.Print("the -d option is not supported by gitea-fmt")
	}
	cmdErrors = append(cmdErrors, giteaFormatGoImports(files, containsString(subArgs, "-l"), containsString(subArgs, "-w")))
	cmdErrors = append(cmdErrors, passThroughCmd("go", append([]string{"run", os.Getenv("GOFUMPT_PACKAGE"), "-extra", "-lang", "1.17"}, substArgs...)))

[wolfogre]

Changed the commits, just removed the broken file and the outdated introduction which confused me 😂

Actually, the comment is correct (but not clear ....), I made some changes to it.

gitea/build/code-batch-process.go

Lines 267 to 273 in a2db810

	switch subCmd {
	case "gitea-fmt":
	if containsString(subArgs, "-d") {
	log.Print("the -d option is not supported by gitea-fmt")
	}
	cmdErrors = append(cmdErrors, giteaFormatGoImports(files, containsString(subArgs, "-l"), containsString(subArgs, "-w")))
	cmdErrors = append(cmdErrors, passThroughCmd("go", append([]string{"run", os.Getenv("GOFUMPT_PACKAGE"), "-extra", "-lang", "1.17"}, substArgs...)))

I see, I dropped the comment deleting.