Change review buttons to icons to make space for text #20934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout on the review code view was broken depending on length of the text before. Change all three buttons to icons with tooltip to make more space for these long texts. Fixes: go-gitea#20922
silverwind
force-pushed
the
review-icon-buttons
branch
from
a4d1abd
to
f6303f2
Compare
KN4CK3R
approved these changes
Aug 24, 2022
GiteaBot
added
the
lgtm/need 1
|
@silverwind Can we change the first icon? We are basically changing the diff behavior for whitespace/EOL. Shouldn't we use a symbol that reflects this? e.g:
|
|
Yeah, I tried other icons for "whitespace" but I'm not sure I found one I like yet. |
|
At least the combined use of gear and three dot icons is a bit confusing as both imply "options". Maybe create a new icon based on these two: https://www.compart.com/en/unicode/U+2423 Quick (ugly) sketch:
|
|
I think I will go with https://www.svgrepo.com/svg/368767/indent-increase because often times the whitespace toggle is related to hiding indendation changes and such. https://www.svgrepo.com/svg/347466/space could also be an option for a generic space icon. |
|
New icon added:
|
zeripath
approved these changes
Aug 25, 2022
GiteaBot
added
lgtm/done
|
. |
|
please backport |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Aug 27, 2022
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts. Fixes: go-gitea#20922
|
-> #20978 |
lafriks
pushed a commit
that referenced
this pull request
Aug 27, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts. Fixes: go-gitea#20922
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 29, 2022
* upstream/main: [skip ci] Updated translations via Crowdin Add instructions how to add service dependencies (go-gitea#20968) Share HTML template renderers and create a watcher framework (go-gitea#20218) [skip ci] Updated licenses and gitignores [skip ci] Updated translations via Crowdin Change review buttons to icons to make space for text (go-gitea#20934) Fix download archiver of a commit (go-gitea#20962)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout on the review code view was broken depending on length of the text. Change all three buttons to icons with tooltip to make more space for these long texts.
Fixes: #20922
Before (broken layout because of too long text):
After:
