Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) #20911

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 22, 2022

Backport #20896

Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL
this causes issues with these large keys.

Therefore increase these fields to MEDIUMTEXT.

Fix #20894

Signed-off-by: Andrew Thornton [email protected]

⚠️ BREAKING ⚠️

Technically this PR should contain a migration but the migration in #20896 cannot be backported to 1.17.
Affected users will have to use gitea doctor recreate-table gpg_key public_key

Only MySQL users will need to do this.

…o-gitea#20896)

Backport go-gitea#20896

Unfortunately some keys are too big to fix within the 65535 limit of TEXT on MySQL
this causes issues with these large keys.

Therefore increase these fields to MEDIUMTEXT.

Unfortunately the migration in go-gitea#20896 cannot be backported to 1.17 so
affected users will have to use `gitea doctor recreate-table gpg_key public_key`

Fix go-gitea#20894

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Aug 22, 2022
@zeripath zeripath added this to the 1.17.2 milestone Aug 22, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2022
@zeripath zeripath merged commit 033178f into go-gitea:release/v1.17 Aug 22, 2022
@zeripath zeripath deleted the backport-20896-v1.17 branch August 22, 2022 14:17
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants