Check if project has the same repository id with issue when assign project to issue #20133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
lunny
requested review from
KN4CK3R,
zeripath and
a1012112796
and removed request for
KN4CK3R and
zeripath
KN4CK3R
reviewed
Jun 26, 2022
GiteaBot
added
the
lgtm/need 2
Co-authored-by: KN4CK3R <[email protected]>
lafriks
approved these changes
Jun 27, 2022
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Jun 27, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #20133 +/- ##
==========================================
- Coverage 46.91% 46.91% -0.01%
==========================================
Files 973 973
Lines 134721 134838 +117
==========================================
+ Hits 63204 63256 +52
- Misses 63768 63825 +57
- Partials 7749 7757 +8
Continue to review full report at Codecov.
|
|
make L-G-T-M work |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jun 30, 2022
…oject to issue (go-gitea#20133) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: Gusted <[email protected]> Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: 6543 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2022
* upstream/main: Fix cli command restore-repo: "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior (go-gitea#20183) [skip ci] Updated translations via Crowdin Fix `dump-repo` git init, fix wrong error type for NullDownloader (go-gitea#20182) Check if project has the same repository id with issue when assign project to issue (go-gitea#20133) [skip ci] Updated translations via Crowdin
6543
added a commit
that referenced
this pull request
Jul 1, 2022
…oject to issue (#20133) (#20188) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: Gusted <[email protected]> Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: 6543 <[email protected]>
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Jul 1, 2022
…0133) - Backport go-gitea#20133 - Check correctly for permission when we fetch a new issue(via ID) is controlled by the user.
6543
added a commit
that referenced
this pull request
Jul 1, 2022
…20196) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: Gusted <[email protected]> Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: 6543 <[email protected]>
tyroneyeh
added a commit
to tyroneyeh/gitea
that referenced
this pull request
Jul 13, 2022
commit 713bc6c Author: 6543 <[email protected]> Date: Tue Jul 12 20:26:27 2022 +0200 Changelog for 1.16.9 (update) (go-gitea#20341) * Changelog for 1.16.9 (update) * update security section commit 6b7e860 Author: Lunny Xiao <[email protected]> Date: Wed Jul 13 01:13:31 2022 +0800 Hide notify mail setting ui if not enabled (go-gitea#20138) (go-gitea#20337) Backport go-gitea#20138 commit 0f89417 Author: Gusted <[email protected]> Date: Tue Jul 12 12:52:20 2022 +0000 Add write check for creating Commit status (go-gitea#20332) (go-gitea#20334) - Backport go-gitea#20332 - Add write code checks for creating new commit status - Regression from go-gitea#5314 - Resolves go-gitea#20331 commit 7c80a0b Author: zeripath <[email protected]> Date: Mon Jul 11 10:15:43 2022 +0100 Ensure that drone tags 1.16.x and 1.16 on push to v1.16.x tag (go-gitea#20304) We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest. We have previously adjusted the manifest to remove the latest tag, and have removed auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being tagged. So here we just state the that we tag x.yy in addition to x.yyz*. Signed-off-by: Andrew Thornton <[email protected]> commit b42df31 Author: zeripath <[email protected]> Date: Wed Jul 6 02:47:16 2022 +0100 Only show Followers that current user can access (go-gitea#20220) (go-gitea#20253) Backport go-gitea#20220 Users who are following or being followed by a user should only be displayed if the viewing user can see them. Signed-off-by: Andrew Thornton <[email protected]> commit 6162fb0 Author: Gusted <[email protected]> Date: Fri Jul 1 17:39:10 2022 +0200 Check for permission when fetching user controlled issues (go-gitea#20133) (go-gitea#20196) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: Gusted <[email protected]> Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: 6543 <[email protected]>
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
…oject to issue (go-gitea#20133) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: Gusted <[email protected]> Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.