Stop spurious APIFormat stopwatches logs #20008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are dangling stopwatches with missing issues there will be repeated logging of Unable to APIFormat stopwatches. These are unhelpful and instead we should only log if the error is not an issue not exist error. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
skip-changelog
Gusted
approved these changes
Jun 17, 2022
GiteaBot
added
the
lgtm/need 1
Signed-off-by: Andrew Thornton <[email protected]>
delvh
approved these changes
Jun 17, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 20, 2022
* giteaofficial/release/v1.17: (35 commits) Simplify and fix migration 216 (go-gitea#20036) Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) (go-gitea#20041) Backtick table name in generic orphan check (go-gitea#20019) (go-gitea#20037) Respond with a 401 on git push when password isn't changed yet (go-gitea#20027) Fix delete pull head ref for DeleteIssue (go-gitea#20032) (go-gitea#20034) use quoted regexp instead of git fixed-value (go-gitea#20030) Dump should only copy regular files and symlink regular files (go-gitea#20015) (go-gitea#20021) Return 404 when tag is broken (go-gitea#20024) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Add fgprof pprof profiler (go-gitea#20005) [skip ci] Updated translations via Crowdin Improve action table indices (go-gitea#19472) Add dbconsistency checks for Stopwatches (go-gitea#20010) fix push mirrors URL are no longer displayed on the UI (go-gitea#20011) Empty log queue on flush and close (go-gitea#19994) [skip ci] Updated translations via Crowdin Stop spurious APIFormat stopwatches logs (go-gitea#20008) Fix CountOrphanedLabels in orphan check (go-gitea#20009) Write Commit-Graphs in RepositoryDumper (go-gitea#20004) ...
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
If there are dangling stopwatches with missing issues there will be repeated logging of Unable to APIFormat stopwatches. These are unhelpful and instead we should only log if the error is not an issue not exist error. And we should also prevent an error on missing issue in GetActiveStopwatch too Signed-off-by: Andrew Thornton <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
If there are dangling stopwatches with missing issues there will be repeated logging of Unable to APIFormat stopwatches. These are unhelpful and instead we should only log if the error is not an issue not exist error. And we should also prevent an error on missing issue in GetActiveStopwatch too Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are dangling stopwatches with missing issues there will be repeated
logging of Unable to APIFormat stopwatches. These are unhelpful and instead
we should only log if the error is not an issue not exist error.
Signed-off-by: Andrew Thornton [email protected]