Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update frontend guideline #19901

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Update frontend guideline #19901

merged 3 commits into from
Jun 6, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang added the type/docs This PR mainly updates/creates documentation label Jun 6, 2022
@wxiaoguang wxiaoguang mentioned this pull request Jun 6, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2022
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 6, 2022

Since you asked me on the PR for sharing my thoughts, I have added comments. I'm okay if you choose to not address them, since you already have your LGTMs.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jun 6, 2022 •
edited
Loading

Thank you very much @Ryuno-Ki , some suggestions are applied.

For the jQuery event namespace and the "us-" prefix, although I prefer to make some strict rules, but it's difficult to put them into practice. Some maintainers have discussed about that "the review of frontend code is too strict and may affect contributors to do contribution (even without these rules applied)", so at the moment I think the document can be more general, and in the future make a poll to decide how the frontend rules should go on.

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 6, 2022

Then I think, this is good to go :)

@techknowlogick techknowlogick merged commit 3d9c02a into go-gitea:main Jun 6, 2022
@wxiaoguang wxiaoguang deleted the update-frontend-guideline branch June 6, 2022 15:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 9, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
320f547 
* giteaofficial/main:
  Prevent NPE whilst migrating if there is a team request review (go-gitea#19855)
  [skip ci] Updated translations via Crowdin
  Add support for rendering terminal output with colors (go-gitea#19497)
  Fix viewed images not loading in a PR (go-gitea#19919)
  Remove out-dated comments (go-gitea#19921)
  Automatically render wiki TOC (go-gitea#19873)
  Improve wording on delete access token modal (go-gitea#19909)
  [skip ci] Updated translations via Crowdin
  Add breaking email restrictions checker in doctor (go-gitea#19903)
  Ensure minimum mirror interval is reported on settings page (go-gitea#19895)
  Improve UX on modal for deleting an access token (go-gitea#19894)
  update discord invite (go-gitea#19907)
  Only log non ErrNotExist errors in git.GetNote  (go-gitea#19884)
  [skip ci] Updated translations via Crowdin
  Update frontend guideline (go-gitea#19901)
  Make AppDataPath absolute against the AppWorkPath if it is not (go-gitea#19815)
@6543 6543 mentioned this pull request Jun 19, 2022
Open
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @lunny @AbdulrhmnGhanem
Update frontend guideline (go-gitea#19901)
9a1bc28 
* update frontend guideline

* "Native" => "Vanilla JS", fix typo comma.

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ryuno-Ki Ryuno-Ki Ryuno-Ki left review comments

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @Ryuno-Ki @lunny @delvh @techknowlogick @GiteaBot