-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve commit list/view on mobile #19712
Conversation
Codecov Report
@@ Coverage Diff @@
## main #19712 +/- ##
==========================================
- Coverage 47.39% 47.33% -0.07%
==========================================
Files 956 958 +2
Lines 133115 133595 +480
==========================================
+ Hits 63093 63235 +142
- Misses 62393 62695 +302
- Partials 7629 7665 +36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
The only thing I noticed is:
Do we perhaps still want to display the (un)verified
icon when present?
That is so small that it can fit even into such a small screen and lets users know whether to trust this commit.
Hmm not sure where to place such item, but definitely a good addition to still have the icon. |
I can see two options for that: Which one do you prefer? Or did I miss an option? |
I think b makes the most sense logically. |
* giteaofficial/main: ContainerRegistry - removed Basic Auth header (go-gitea#19735) [skip ci] Updated translations via Crowdin Add changelog for v1.16.8 (go-gitea#19724) (go-gitea#19730) Improve commit list/view on mobile (go-gitea#19712)
I appreciate the work done in this PR and on improving the mobile UX overall. |
The commit hash is simply too long to be shown on a screen where horizontal space is very limited. In my viewpoint, I never really use the commit hash from such list unless I want to have a commit hash from a specific commit(which is now on mobile one more click away). Yeah I wanted to some work on commit signing status but got stalled by school, but now it's already merged 🤷🏽. |
understood, that's fair, I guess it can get used to. mobile is not a workstation anyway (convergence yay)..
oh..it's fine then, really. perhaps another time? |
- This is a continuation on [the work](go-gitea#19546) I've done for improving mobile experience on Gitea. - The current behavior of going trough the commits list is horrible, each individual item gets it's own row and thereby isn't quite compact as it should be on mobile. The commit view's header is in a bit better state, it's quite only that content is overlapping each other. - This patch fixes those problems. Each row in the commit list table will actually take a row in the UI. The commit view's header has now a better organized way of placing the information.
Before
After