Simplify IsVendor
#19626
Merged
Simplify IsVendor
#19626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the provided function by go-enry. This file was actually more or less duplicated code from go-enry: https://github.com/go-enry/go-enry/blob/ed2adad15906ed7f262e64b502eb91de08176314/utils.go#L139-L246
Gusted
added
the
type/refactoring
|
Oh Yes! Upstream has the optimization. |
GiteaBot
added
the
lgtm/need 2
|
IIRC, this optimization was upstreamed into enry, so it might indeed be possible to remove it here. cc @zeripath. |
wxiaoguang
approved these changes
May 6, 2022
There was a problem hiding this comment.
Upstream has the optimization already. LGTM
https://github.com/go-enry/go-enry/releases/tag/v2.7.0
Gitea uses: github.com/go-enry/go-enry/v2 v2.7.1
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
May 6, 2022
GiteaBot
added
lgtm/done
|
Yes @zeripath did submit this optimization upstream and it was already merged |
No... the go-enry code duplicates this code.
yup: go-enry/go-enry#44 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 6, 2022
* giteaofficial/main: Simplify `IsVendor` (go-gitea#19626) Prevent NPE when checking repo units if the user is nil (go-gitea#19625) Skip duplicated layers. (go-gitea#19624) Add "Reference" section to Issue view sidebar (go-gitea#19609) GetFeeds must always discard actions with dangling repo_id (go-gitea#19598)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
The changes in this file were upstreamed directly into go-enry as go-enry/go-enry#44 and therefore they are no longer needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this file were upstreamed directly into go-enry as go-enry/go-enry#44
and therefore they are no longer needed.