Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage #19572

Merged
merged 5 commits into from
May 1, 2022
Merged

Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage #19572

merged 5 commits into from
May 1, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented May 1, 2022 •
edited
Loading

  • dont overwrite err with nil unintentionaly
  • rename CheckPRReadyToMerge to CheckPullBranchProtections
  • rename prQueue to prPatchCheckerQueue

from #9307

@6543 6543 added this to the 1.17.0 milestone May 1, 2022
6543 added 2 commits May 1, 2022 23:18
@6543
ajust to unrefactored code
848dc5e
@6543
refactor: rename prQueue 2 prPatchCheckerQueue
840ee6a 
since there will be more queues related to pulls, use a meaningfull name
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 1, 2022
@6543 6543 changed the title CheckPullMergable check all branch protections! CheckPullMergable check all branch protections May 1, 2022
delvh
delvh approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't exactly understand why the variables were renamed.
I think the previous name was more understandable.

Apart from that: LGTM.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 1, 2022
@6543
Copy link
Member Author

6543 commented May 1, 2022 •
edited
Loading

as per commit message: ...since there will be more queues related to pulls, use a meaningfull name :)

@6543 6543 requested a review from Gusted May 1, 2022 22:37
@6543 6543 changed the title CheckPullMergable check all branch protections Rename Pull Checking functions to reflect there usage May 1, 2022
Gusted
Gusted approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2022
@6543 6543 changed the title Rename Pull Checking functions to reflect there usage Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage May 1, 2022
delvh
delvh reviewed May 1, 2022
View reviewed changes
services/pull/check.go Outdated Show resolved Hide resolved
services/pull/check.go Outdated Show resolved Hide resolved
6543 added a commit to 6543-forks/gitea that referenced this pull request May 1, 2022
@6543
Dont overwrite err with nil (part go-gitea#19572)
56c353b
@6543 6543 mentioned this pull request May 1, 2022
Merged
@6543
Copy link
Member Author

6543 commented May 1, 2022

#19574

@6543 6543 added the backport/done All backports for this PR have been created label May 1, 2022
6543 added a commit that referenced this pull request May 1, 2022
@6543
Dont overwrite err with nil (part #19572) (#19574)
f7330fd 
* Dont overwrite err with nil (part #19572)


Co-authored-by: Gusted <[email protected]>
@6543 6543 merged commit d8905cb into go-gitea:main May 1, 2022
@6543 6543 deleted the CheckPullMergable_check_all_branch_protections branch May 1, 2022 23:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
94f1981 
* giteaofficial/main:
  Fix some slice problems (incorrect slice length) (go-gitea#19592)
  Fix sending empty notifications (go-gitea#19589)
  Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552)
  Remove legacy `+build:` constraint (go-gitea#19582)
  Federation: return useful statistic information for nodeinfo (go-gitea#19561)
  Upgrade required git version to 2.0 (go-gitea#19577)
  add smtp password to install page (go-gitea#17564)
  ignore DNS error when doing migration allow/block check (go-gitea#19566)
  [skip ci] Updated translations via Crowdin
  Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572)
  Improve UI on mobile (go-gitea#19546)
  Add API to check if team has repo access (go-gitea#19540)
@delvh delvh mentioned this pull request May 3, 2022
Merged
19 tasks
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @delvh @AbdulrhmnGhanem
Dont overwrite err with nil & rename PullCheckingFuncs to reflect the…
3421813 
…re usage (go-gitea#19572)

- dont overwrite err with nil unintentionaly
- rename CheckPRReadyToMerge to CheckPullBranchProtections
- rename prQueue to prPatchCheckerQueue

from go-gitea#9307

Co-authored-by: delvh <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @Gusted @delvh @GiteaBot