-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more context for models #19511
Merged
Merged
more context for models #19511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Apr 26, 2022
the end result will be to have it similar to what we do with the gitRepo for DB transactions ... |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 26, 2022
3 tasks
zeripath
reviewed
Apr 26, 2022
Co-authored-by: zeripath <[email protected]>
lunny
reviewed
Apr 27, 2022
lunny
reviewed
Apr 27, 2022
lunny
reviewed
Apr 27, 2022
Generally LGTM except some comments. |
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 27, 2022
zeripath
reviewed
Apr 27, 2022
wxiaoguang
reviewed
Apr 28, 2022
wxiaoguang
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WithContext could be more handy than TxContext in some cases.
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 28, 2022
:) |
wxiaoguang
approved these changes
Apr 28, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 29, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Support `hostname:port` to pass host matcher's check go-gitea#19543 (go-gitea#19543) Add "Allow edits from maintainer" feature (go-gitea#18002) Better describe what `/repos/{owner}/{repo}/raw/{filepath}` returns on 200 (go-gitea#19542) more context for models (go-gitea#19511)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
make more usage of context, to have more db transaction in one session (make diff of go-gitea#9307 smaller)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make more usage of context, to have more db transaction in one session
(make diff of #9307 smaller)