Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only request write when necessary #18657 #19422

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 19, 2022

backport #18657

  • Only request write when necessary
  • Fix perm

  • Update setting.go

  • Update setting.go

  • Update setting.go

Co-authored-by: wxiaoguang [email protected]
Co-authored-by: zeripath [email protected]

* Only request write when necessary

- Only request write for `INTERNAL_TOKEN_URI` when no token was found.
- Resolves go-gitea#18655

* Fix perm

* Update setting.go

* Update setting.go

* Update setting.go

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: zeripath <[email protected]>
@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 19, 2022
@lunny lunny added this to the 1.16.6 milestone Apr 19, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2022
@techknowlogick techknowlogick merged commit 9b47469 into go-gitea:release/v1.16 Apr 19, 2022
@lunny lunny deleted the ini-read branch April 20, 2022 00:39
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants