Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix global packages enabled avaiable #19276

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Fix global packages enabled avaiable #19276

merged 5 commits into from
Mar 31, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 31, 2022

Fix #19275

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 31, 2022
@lunny lunny requested review from KN4CK3R and delvh March 31, 2022 08:47
delvh
delvh reviewed Mar 31, 2022
View reviewed changes
routers/api/packages/api.go Outdated Show resolved Hide resolved
routers/api/packages/api.go Outdated Show resolved Hide resolved
routers/web/web.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2022
@lunny lunny force-pushed the lunny/fix_packages_global_enabled branch from 296b20a to e4b372e Compare March 31, 2022 14:13
@lunny
Copy link
Member Author

lunny commented Mar 31, 2022

@delvh done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2022
@delvh
Copy link
Member

delvh commented Mar 31, 2022 •
edited
Loading

I just noticed: We should update the swagger docs for this return value.

@6543 6543 added this to the 1.17.0 milestone Mar 31, 2022
@lunny lunny force-pushed the lunny/fix_packages_global_enabled branch from fb2a677 to 092b07d Compare March 31, 2022 16:41
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2022
@6543 6543 merged commit 420851c into go-gitea:main Mar 31, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 1, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
dd36434 
* giteaoffical/main:
  Fix broken of team create (go-gitea#19288)
  Remove `git.Command.Run` and `git.Command.RunInDir*` (go-gitea#19280)
  Performance improvement for add team user when org has more than 1000 repositories (go-gitea#19227)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#19281)
  Fix container download counter (go-gitea#19287)
  go.mod: update kevinburke/ssh_config to v1.2.0 (go-gitea#19286)
  Fix global packages enabled avaiable (go-gitea#19276)
  Add Goroutine stack inspector to admin/monitor (go-gitea#19207)
  Move checks for pulls before merge into own function (go-gitea#19271)
  Restore user autoregistration with email addresses (go-gitea#19261)
  Improve sync performance for pull-mirrors (go-gitea#19125)
  Refactor `git.Command.Run*`, introduce `RunWithContextString` and `RunWithContextBytes` (go-gitea#19266)
  Move reaction to models/issues/ (go-gitea#19264)
@BlackOrca
Copy link

My problem is i cannot activate the packages functionality.
Is a workaround to activate the packages while this fix comes to a new Release?

@6543
Copy link
Member

6543 commented Apr 5, 2022

@BlackOrca It's not released - if you use docker you have to use the dev tag ...

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 5, 2022
@lunny lunny deleted the lunny/fix_packages_global_enabled branch April 5, 2022 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@delvh delvh delvh approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Disabling the package registry does not work
6 participants
@lunny @delvh @BlackOrca @6543 @KN4CK3R @GiteaBot