Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use goproxy.io instead of goproxy.cn #19242

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Use goproxy.io instead of goproxy.cn #19242

merged 1 commit into from
Mar 28, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 28, 2022

Looks like goproxy.cn is not stable any more.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 28, 2022
@wxiaoguang
Copy link
Contributor

I think we can just remove the GOPROXY setting, and let users set their own environment variables.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 28, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2022
@lafriks lafriks merged commit 54961f3 into go-gitea:main Mar 28, 2022
@lafriks
Copy link
Member

lafriks commented Mar 28, 2022

I think we can just remove the GOPROXY setting, and let users set their own environment variables.

This is for our build system, it does not affect users/developers

@wxiaoguang
Copy link
Contributor

I think we can just remove the GOPROXY setting, and let users set their own environment variables.

This is for our build system, it does not affect users/developers

I know, I mean if any user need to run that build, they can set environments by themselves.

And, why our build system need the GOPROXY? Cannot these agents connect to golang or github site?

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Mar 29, 2022
@lunny @6543
Use goproxy.io instead of goproxy.cn (go-gitea#19242)
8ee0c74
@6543 6543 mentioned this pull request Mar 29, 2022
Merged
@6543 6543 added backport/done All backports for this PR have been created backport/v1.16 labels Mar 29, 2022
@6543
Copy link
Member

6543 commented Mar 29, 2022

-> #19246

@lunny lunny deleted the lunny/goproxy.io branch March 29, 2022 00:34
@6543 6543 added this to the 1.17.0 milestone Mar 29, 2022
@lafriks
Copy link
Member

lafriks commented Mar 29, 2022

I know, I mean if any user need to run that build, they can set environments by themselves.

And, why our build system need the GOPROXY? Cannot these agents connect to golang or github site?

I don't think anyone is running his own drone himself for gitea as this pipeline is quite specific, for developers we have makefile

@silverwind
Copy link
Member

silverwind commented Mar 29, 2022 •
edited
Loading

For drone, one can set DRONE_RUNNER_ENV_FILE and in that file you can define for example GOPROXY="https://proxy.golang.org", eliminating the need to having to do this in every .drone.yml. Similarily, if users want to use another proxy, they should set it in their environment instead.

zeripath pushed a commit that referenced this pull request Mar 29, 2022
@6543 @lunny
Use goproxy.io instead of goproxy.cn (#19242) (#19246)
d59b854 
Co-authored-by: Lunny Xiao <[email protected]>
@wxiaoguang
Copy link
Contributor

I know, I mean if any user need to run that build, they can set environments by themselves.
And, why our build system need the GOPROXY? Cannot these agents connect to golang or github site?

I don't think anyone is running his own drone himself for gitea as this pipeline is quite specific, for developers we have makefile

@lafriks My question is "why our build system need the GOPROXY? Cannot these agents connect to golang or github site?", is there an answer?

@lafriks
Copy link
Member

lafriks commented Mar 29, 2022 •
edited
Loading

Because as we don't use vendor directory anymore and if one of sites where dependencies are downloaded from is down our build system would also stop. For example not all dependencies are on github alone but some are also on private servers that could be easily inaccessible time to time. go proxy stores all dependency copy indefinitely so we can be sure that we will be able to download them even if original sites are down.

attels

@lafriks
Copy link
Member

lafriks commented Mar 29, 2022

oh, and using goproxy is also faster as you don't have to clone whole source repository (git) but only packed files for that version

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
f6c0470 
* giteaoffical/main: (31 commits)
  Add Package Registry (go-gitea#16510)
  Show messages for users if the ROOT_URL is wrong, show JavaScript errors (go-gitea#18971)
  [skip ci] Updated translations via Crowdin
  Make git.OpenRepository accept Context (go-gitea#19260)
  Use full output of git show-ref --tags to get tags for PushUpdateAddTag (go-gitea#19235)
  When conflicts have been previously detected ensure that they can be resolved (go-gitea#19247)
  More commit info from API (go-gitea#19252)
  Move some issue methods as functions (go-gitea#19255)
  Move project files into models/project sub package (go-gitea#17704)
  Granular webhook events in editHook (go-gitea#19251)
  Provide configuration to allow camo-media proxying (go-gitea#12802)
  Move init repository related functions to modules (go-gitea#19159)
  Move organization related structs into sub package (go-gitea#18518)
  Refactor repo clone button and repo clone links, fix JS error on empty repo page (go-gitea#19208)
  Show last cron messages on monitor page (go-gitea#19223)
  Allow API to create file on empty repo (go-gitea#19224)
  Use goproxy.io instead of goproxy.cn (go-gitea#19242)
  New cron task: delete old system notices (go-gitea#19219)
  Let web and API routes have different auth methods group (go-gitea#19168)
  Only send webhook events to active system webhooks and only deliver to active hooks (go-gitea#19234)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @wxiaoguang @lafriks @6543 @silverwind @jolheiser @GiteaBot