Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cron task no notice on success #19221

Merged
merged 3 commits into from
Mar 26, 2022
Merged

Make cron task no notice on success #19221

merged 3 commits into from
Mar 26, 2022

Commits on Mar 26, 2022

  1. Make cron task no notice on success 

    Change all cron tasks to make them no notice on success default. Instead if a user
wants notices on success they need to add NOTICE_ON_SUCCESS=true instead.

 ## ⚠️ BREAKING ⚠️

This changes the cron config so that notices on success are no longer set by default
and breaks NO_SUCCESS_NOTICE settings. Instead users who want notices on success
must set NOTICE_ON_SUCCESS=true instead.

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    fca7813 View commit details
    Browse the repository at this point in the history

  2. Update custom/conf/app.example.ini 

    Co-authored-by: Norwin <[email protected]>
    @zeripath @noerw
    zeripath and noerw authored Mar 26, 2022
    Configuration menu
    Copy the full SHA
    ef8a34e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into no-notice-on-success

    @zeripath
    zeripath authored Mar 26, 2022
    Configuration menu
    Copy the full SHA
    a1fecf2 View commit details
    Browse the repository at this point in the history