Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If rendering has failed due to a net.OpError stop rendering (attempt 2) (#19049) #19056

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

zeripath
Copy link
Contributor

Backport #19049

Unfortunately #18642 does not work because a *net.OpError does not implement
the Is interface to make errors.Is work correctly - thus leading to the
irritating conclusion that a *net.OpError is not a *net.OpError.

Here we keep the errors.Is because presumably this will be fixed at
some point in the golang main source code but also we add a simply type
cast to also check.

Fix #18629

Signed-off-by: Andrew Thornton [email protected]

…2) (go-gitea#19049)

Backport go-gitea#19049

Unfortunately go-gitea#18642 does not work because a `*net.OpError` does not implement
the `Is` interface to make `errors.Is` work correctly - thus leading to the
irritating conclusion that a `*net.OpError` is not a `*net.OpError`.

Here we keep the `errors.Is` because presumably this will be fixed at
some point in the golang main source code but also we add a simply type
cast to also check.

Fix go-gitea#18629

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.16.4 milestone Mar 10, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2022
@6543 6543 merged commit 0fe99cc into go-gitea:release/v1.16 Mar 10, 2022
@zeripath zeripath deleted the backport-19049-v1.16 branch March 10, 2022 21:17
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants