Fix potential assignee query for repo #18994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeripath I think you should check this. |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Mar 3, 2022
GiteaBot
added
lgtm/need 1
Gusted
approved these changes
Mar 3, 2022
GiteaBot
added
lgtm/done
|
Time to add a test for this function? 😅 |
|
If someone would like to assist me there, I'm not yet familiar with the test system for Gitea ... |
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Mar 3, 2022
|
@fnetX https://github.com/fnetX/gitea/pull/3 The code should be relatively self-explanatory. The "mocked" database files are loaded from |
Codecov Report
@@ Coverage Diff @@
## main #18994 +/- ##
=======================================
Coverage ? 46.59%
=======================================
Files ? 854
Lines ? 122819
Branches ? 0
=======================================
Hits ? 57227
Misses ? 58676
Partials ? 6916
Continue to review full report at Codecov.
|
lunny
approved these changes
Mar 4, 2022
lunny
added
backport/v1.16
skip-changelog
Gusted
approved these changes
Mar 4, 2022
|
@lunny has been merged. |
lunny
pushed a commit
that referenced
this pull request
Mar 4, 2022
* Fix potential assignee query for repo * Add tests for `GetRepoAssignees` - As per #18994 (comment) Co-authored-by: Gusted <[email protected]>
|
make lgtm work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 6, 2022
* giteaofficial/main: Fix EasyMDE error when input Enter (go-gitea#19004) Fix update hint bug (go-gitea#18996) Fix the editor height in review box (go-gitea#19003) Add a "admin user generate-access-token" subcommand (go-gitea#17722) Fix potential assignee query for repo (go-gitea#18994) Add config option to disable "Update branch by rebase" (go-gitea#18745) Update `go-enry` to v2.8.0 (go-gitea#18993) homebrew updates via cron ignore missing comment for user notifications (go-gitea#18954) allow overwrite artifacts for github releases (go-gitea#18987) fix & refactor (go-gitea#18973)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Fix potential assignee query for repo * Add tests for `GetRepoAssignees` - As per go-gitea#18994 (comment) Co-authored-by: 6543 <[email protected]> Co-authored-by: Gusted <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18992