Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max text height to prevent overflow (#18862) #18977

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Set max text height to prevent overflow (#18862) #18977

merged 3 commits into from
Mar 2, 2022

Conversation

fnetX
Copy link
Contributor

@fnetX fnetX commented Mar 2, 2022

Backport #18862

Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button.

Before:
image

After:
image

Interestingly, I don't see this bug on Firefox.

@kdumontnu @fnetX
Set max text height to prevent overflow (#18862)
bbfde6b 
Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button.

Before:
![image](https://user-images.githubusercontent.com/12700993/155253001-e1dab086-aaf3-4338-889d-6a861728274a.png)

After:
![image](https://user-images.githubusercontent.com/12700993/155253144-5b9a3547-9582-412f-867f-41a45a14a0fe.png)

Interestingly, I don't see this bug on Firefox.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2022
@6543 6543 added this to the 1.16.3 milestone Mar 2, 2022
@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 2, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2022
@zeripath zeripath merged commit f4b96c1 into go-gitea:release/v1.16 Mar 2, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.3
Development

Successfully merging this pull request may close these issues.
6 participants
@fnetX @6543 @Gusted @zeripath @GiteaBot @kdumontnu