Fix redirect when using lowercase repo name

[AbdulrhmnGhanem]

Fixes ##18774.

[silverwind]

It feels like the wrong fix, especially setting.AppSubURL may contain significant case and that is eliminated here, which can be bad. Not sure I fully understand the issue but it would be better to accept both case variants in the router instead.

[AbdulrhmnGhanem]

It feels like the wrong fix, especially setting.AppSubURL

You are right about this one. Changed it to

prefix := strings.TrimPrefix(setting.AppSubURL+strings.ToLower(strings.TrimSuffix(ctx.Req.URL.Path, ctx.Params("*"))), strings.ToLower(ctx.Repo.RepoLink))

it would be better to accept both case variants in the router instead.

The bug in the RepoRefLegacy handling:

gitea/modules/context/repo.go

Lines 915 to 917 in 616146f

	if refType == RepoRefLegacy {
	// redirect from old URL scheme to new URL scheme
	prefix := strings.TrimPrefix(setting.AppSubURL+strings.TrimSuffix(ctx.Req.URL.Path, ctx.Params("*")), ctx.Repo.RepoLink)

other RepoRefTypes are handled right and not in the router:

gitea/routers/web/web.go

Lines 1017 to 1024 in 616146f

	m.Group("/raw", func() {
	m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownload)
	m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownload)
	m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownload)
	m.Get("/blob/{sha}", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByID)
	// "/*" route is deprecated, and kept for backward compatibility
	m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownload)
	}, repo.MustBeNotEmpty, reqRepoCodeReader)

for consistency, I don't think this should be handled in the router.

[lunny]

@AbdulrhmnGhanem Could you rebase and then we can merge this PR.

[lunny]

make L-G-T-M work.

[fnetX]

We just hit this bug at Codeberg immediately after deployment. Should I send a backport? Was this forgotten? (I think I'll do)

[Gusted]

Was this forgotten?

This was marked as enhancement(not sure why), we only backport PR's marked as bug fixes. Feel free to backport.

[fnetX]

Well it got the backport label, so it appeared to me as intended for backporting.