Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dangling GetAttribute calls (#18754) #18755

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Prevent dangling GetAttribute calls (#18754) #18755

merged 5 commits into from
Feb 14, 2022

Commits on Feb 13, 2022

  1. Prevent dangling GetAttribute calls 

    It appears possible that there could be a hang due to unread data from the
repo-attribute command pipes. This PR simply closes these during the defer.

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    0ee28ec View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. move close into the defer 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    36e5828 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/release/v1.16' into fix-dangling… 

    …-get-attributes-1.16
    @zeripath
    zeripath committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a75c290 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/release/v1.16' into fix-dangling… 

    …-get-attributes-1.16
    @zeripath
    zeripath committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    f40abb9 View commit details
    Browse the repository at this point in the history

  4. lets try again 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    4db28fc View commit details
    Browse the repository at this point in the history