Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing i18n key for update checker (#18646) #18665

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

wxiaoguang
Copy link
Contributor

Backport #18646

Since 1.16 won't get new translations from crowdin, so I am not sure what's the best way to backport, maybe showing the en-US text is enough.

@wxiaoguang wxiaoguang added this to the 1.16.2 milestone Feb 8, 2022
@lunny
Copy link
Member

lunny commented Feb 8, 2022

Just change the translation files directly.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2022
@zeripath
Copy link
Contributor

zeripath commented Feb 8, 2022

There won't actually be many translations available for this at present. We'll have to collect them in a few days or even weeks.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2022
@lafriks lafriks merged commit 8671602 into go-gitea:release/v1.16 Feb 8, 2022
@wxiaoguang wxiaoguang deleted the backport-update-i18n branch February 8, 2022 09:53
@zeripath zeripath changed the title Backport: fix the missing i18n key for update checker (#18646) Fix the missing i18n key for update checker (#18646) Feb 21, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants