Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues not updated by commits #16254

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jun 25, 2021

UpdateIssuesCommit may get called with fewer commits because of FeedMaxCommitNum and therefore may miss some commands.

@KN4CK3R KN4CK3R added this to the 1.15.0 milestone Jun 25, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16254 (ac2ed8d) into main (622f1e7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16254   +/-   ##
=======================================
  Coverage   45.46%   45.46%           
=======================================
  Files         708      708           
  Lines       83418    83418           
=======================================
+ Hits        37925    37930    +5     
+ Misses      39419    39416    -3     
+ Partials     6074     6072    -2     
Impacted Files Coverage Δ
services/repository/push.go 46.92% <0.00%> (ø)
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 42.42% <0.00%> (+0.43%) ⬆️
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622f1e7...ac2ed8d. Read the comment docs.

@zeripath zeripath merged commit e673e42 into go-gitea:main Jun 26, 2021
@zeripath
Copy link
Contributor

Please send backport

KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jun 26, 2021
`UpdateIssuesCommit` may get called with fewer commits because of `FeedMaxCommitNum` and therefore may miss some commands.
6543 pushed a commit that referenced this pull request Jun 26, 2021
`UpdateIssuesCommit` may get called with fewer commits because of `FeedMaxCommitNum` and therefore may miss some commands.
@6543 6543 added the backport/done All backports for this PR have been created label Jun 26, 2021
@KN4CK3R KN4CK3R deleted the fix-update-issues-commit branch June 27, 2021 21:06
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
`UpdateIssuesCommit` may get called with fewer commits because of `FeedMaxCommitNum` and therefore may miss some commands.
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants