Fix panic in unique persistable channel queue #16072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an incorrect casting in the wrapped queue. Fix go-gitea#16071 Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Jun 5, 2021
GiteaBot
added
the
lgtm/need 1
lunny
reviewed
Jun 5, 2021
| @@ -188,7 +188,7 @@ func (q *PersistableChannelUniqueQueue) Run(atShutdown, atTerminate func(func()) | |||
| go q.internal.Run(func(_ func()) {}, func(_ func()) {}) | |||
| go func() { | |||
| _ = q.internal.Flush(0) | |||
| log.Debug("LevelUniqueQueue: %s flushed so shutting down", q.internal.(*LevelQueue).Name()) | |||
There was a problem hiding this comment.
I want to know if line 197 also may panic?
There was a problem hiding this comment.
But it also q.internal.(*LevelUniqueQueue) when luq, ok := q.internal.(*LevelUniqueQueue); !ok
There was a problem hiding this comment.
it's only assigned to LevelUniqueQueue.
There was a problem hiding this comment.
so maybe if q.internal.(*LevelUniqueQueue).ByteFIFOUniqueQueue.byteFIFO.Len(luq.shutdownCtx) != 0 will not make confusion.
Codecov Report
@@ Coverage Diff @@
## main #16072 +/- ##
=======================================
Coverage 44.08% 44.08%
=======================================
Files 683 683
Lines 82442 82442
=======================================
+ Hits 36341 36344 +3
+ Misses 40187 40182 -5
- Partials 5914 5916 +2
Continue to review full report at Codecov.
|
6543
approved these changes
Jun 5, 2021
GiteaBot
added
lgtm/done
|
look's like a copy paste issue ;) |
zeripath
added
the
skip-changelog
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
There is an incorrect casting in the wrapped queue. Fix go-gitea#16071 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incorrect casting in the wrapped queue.
Fix #16071
Signed-off-by: Andrew Thornton [email protected]