Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where repositories appear unadopted #15757

Merged
merged 3 commits into from
May 7, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 6, 2021

Fix bug where repositories with capital letters in their names appear unadopted.

Fix #15755

Fix bug where repositories with capital letters in their names appear unadopted.

Fix go-gitea#15755
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15757 (64c3223) into main (edb8389) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15757      +/-   ##
==========================================
+ Coverage   43.84%   43.94%   +0.10%     
==========================================
  Files         678      678              
  Lines       81945    81945              
==========================================
+ Hits        35927    36009      +82     
+ Misses      40161    40061     -100     
- Partials     5857     5875      +18     
Impacted Files Coverage Δ
modules/repository/adopt.go 0.00% <0.00%> (ø)
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
services/pull/check.go 26.02% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
services/pull/pull.go 43.37% <0.00%> (ø)
models/error.go 39.84% <0.00%> (+0.31%) ⬆️
routers/api/v1/repo/pull.go 28.74% <0.00%> (+0.59%) ⬆️
models/notification.go 66.07% <0.00%> (+0.88%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb8389...64c3223. Read the comment docs.

@lunny lunny merged commit 114c85e into go-gitea:main May 7, 2021
@lunny
Copy link
Member

lunny commented May 7, 2021

Please send backport to v1.14

@zeripath zeripath deleted the Fix-15755-capital-unadopted branch May 7, 2021 06:08
6543 pushed a commit to 6543-forks/gitea that referenced this pull request May 7, 2021
Fix bug where repositories with capital letters in their names appear unadopted.

Fix go-gitea#15755

Co-authored-by: Lunny Xiao <[email protected]>
@6543 6543 added the backport/done All backports for this PR have been created label May 7, 2021
@6543
Copy link
Member

6543 commented May 7, 2021

-> #15767

6543 added a commit that referenced this pull request May 7, 2021
Fix bug where repositories with capital letters in their names appear unadopted.

Fix #15755

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
Fix bug where repositories with capital letters in their names appear unadopted.

Fix go-gitea#15755

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repositories w/ capital letters in their names show up as unadopted
6 participants