Set GIT_DIR correctly if it is not set #15751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#15744 Signed-off-by: Andrew Thornton <[email protected]>
silverwind
reviewed
May 6, 2021
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
silverwind
approved these changes
May 6, 2021
GiteaBot
added
lgtm/need 1
|
Using https://github.com/lithammer/dedent would be even nicer 😉 |
6543
approved these changes
May 7, 2021
GiteaBot
added
lgtm/done
|
I think the first commit was nice to see the diff itself, and how it is formatted now is totally fine. to "dedent": I think we should not add to much boilerplate ... |
|
Yes the diff is kind of destroyed with the reformatting. Dedent is optional but I still think worth it because code is much more often read than written and that's just more pleasureable if properly indented :) |
A go-template or even destroy these hook files and make them unnecessary by using core.hooksPath cleverly. |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
May 7, 2021
* Set GIT_DIR correctly if it is not set * Expand out templates Signed-off-by: Andrew Thornton <[email protected]>
|
-> #15769 |
6543
added a commit
that referenced
this pull request
May 7, 2021
* Set GIT_DIR correctly if it is not set * Expand out templates Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Set GIT_DIR correctly if it is not set * Expand out templates Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15744
Signed-off-by: Andrew Thornton [email protected]