Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Graph: Pull-Requests should not link to issues #15734

Merged
merged 1 commit into from
May 5, 2021
Merged

Commit Graph: Pull-Requests should not link to issues #15734

merged 1 commit into from
May 5, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 5, 2021

fixes #15730

@KN4CK3R KN4CK3R changed the title Pull-Requests should link to issues Pull-Requests should not link to issues May 5, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2021
@lunny lunny added the type/bug label May 5, 2021
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label May 5, 2021
@6543 6543 added this to the 1.15.0 milestone May 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2021
@6543 6543 changed the title Pull-Requests should not link to issues Commit Graph: Pull-Requests should not link to issues May 5, 2021
@6543 6543 merged commit 5e98d67 into go-gitea:main May 5, 2021
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

I understand there was an edge case this was supposed to fix but it caused another issue.
I am mirroring this repo.
Issue tracker is set to external and links to GH's issue tracker of this repo.
I disabled PR's for the repo since it's a mirror and that's no place to accept PR's.
PR links (since they were linking to issues) were being redirected the same way as issues were as an external issue tracker is set -> they redirected to GH PR links.
This is now broken and I get linked to a 404 on my instance, because obviously the mirror doesn't have any PR's to show there, since a) PR's are disabled there and b) it's a mirror and yeah, DRY.
Could something be done about this?

@zeripath
Copy link
Contributor

zeripath commented May 5, 2021

yeah I knew there was a reason why I didn't use /pulls for this

@6543
Copy link
Member

6543 commented May 5, 2021

ok we should add it back with a note that this is intended, the smal refactor is still nice :)

@6543 6543 mentioned this pull request May 5, 2021
Merged
@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed type/bug topic/ui Change the appearance of the Gitea UI labels May 5, 2021
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

yeah I knew there was a reason why I didn't use /pulls for this

ikr, I recall at some point we were even talking about it..

@6543
Copy link
Member

6543 commented May 5, 2021

#15740 is ready to fix this, only the comment could be improved ...

techknowlogick pushed a commit that referenced this pull request May 6, 2021
@6543 @zeripath
reverse #15734 partial and comment (#15740)
6a3ad0b 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@KN4CK3R KN4CK3R deleted the fix-pulls-link branch May 7, 2021 06:25
6543 pushed a commit to 6543-forks/gitea that referenced this pull request May 7, 2021
@KN4CK3R @6543
Commit Graph: Pull-Requests should not link to issues (go-gitea#15734)
620bf98 
Use `/pulls` and simplify code.
6543 added a commit to 6543-forks/gitea that referenced this pull request May 7, 2021
@6543 @zeripath
reverse go-gitea#15734 partial and comment (go-gitea#15740)
046c09e 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@6543 6543 mentioned this pull request May 7, 2021
Merged
techknowlogick pushed a commit that referenced this pull request May 7, 2021
@6543 @KN4CK3R @zeripath
Use pulls in commit graph unless pulls are disabled (#15734 & #15740 & …
7871094 
…#15774) (#15775)

* Commit Graph: Pull-Requests should not link to issues (#15734)

Use `/pulls` and simplify code.

* reverse #15734 partial and comment (#15740)

* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>

* Use pulls in commit graph unless pulls are disabled

Fix #15370

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: KN4CK3R <[email protected]>
Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@KN4CK3R @AbdulrhmnGhanem
Commit Graph: Pull-Requests should not link to issues (go-gitea#15734)
0a6fa13 
Use `/pulls` and simplify code.
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @zeripath @AbdulrhmnGhanem
reverse go-gitea#15734 partial and comment (go-gitea#15740)
4f0e3a8 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Commit Graph: Pull-Requests should not link to issues
6 participants
@KN4CK3R @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @zeripath @6543 @lunny @GiteaBot