Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Backoff for ByteFIFO #15724

Merged
merged 8 commits into from
May 8, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 4, 2021

This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Related #15542

Signed-off-by: Andrew Thornton [email protected]

This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.15.0 milestone May 4, 2021
@zeripath
Copy link
Contributor Author

zeripath commented May 4, 2021

Related #15542

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2021
@zeripath
Copy link
Contributor Author

zeripath commented May 4, 2021

This could easily be moved in to #15693

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #15724 (f5dd4c0) into main (2a9b8d1) will increase coverage by 0.01%.
The diff coverage is 72.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15724      +/-   ##
==========================================
+ Coverage   43.96%   43.98%   +0.01%     
==========================================
  Files         678      678              
  Lines       81998    82016      +18     
==========================================
+ Hits        36053    36074      +21     
+ Misses      40072    40069       -3     
  Partials     5873     5873              
Impacted Files Coverage Δ
modules/queue/queue_bytefifo.go 81.20% <72.09%> (+1.05%) ⬆️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
modules/queue/workerpool.go 52.74% <0.00%> (+1.09%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9b8d1...f5dd4c0. Read the comment docs.

lafriks
lafriks previously requested changes May 8, 2021
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit but otherwise looks good

@6543 6543 requested a review from lunny May 8, 2021 14:56
@zeripath zeripath merged commit e22ee46 into go-gitea:main May 8, 2021
@zeripath zeripath deleted the exponential-backoff-for-bytefifo branch May 8, 2021 16:29
6543 pushed a commit to 6543-forks/gitea that referenced this pull request May 8, 2021
This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@6543 6543 added the backport/done All backports for this PR have been created label May 8, 2021
@6543
Copy link
Member

6543 commented May 8, 2021

-> #15793

techknowlogick pushed a commit that referenced this pull request May 8, 2021
This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@zeripath zeripath mentioned this pull request May 9, 2021
12 tasks
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/cpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants