Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webkit calendar icon color on arc-green #15713

Merged
merged 5 commits into from
May 4, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 3, 2021

Before:
Screen Shot 2021-05-04 at 00 13 17

After:
image

There seems to be no way to set a color according to this, so it has to be a filter.

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label May 3, 2021
@silverwind silverwind added this to the 1.15.0 milestone May 3, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 3, 2021
@silverwind
Copy link
Member Author

Actually found a better way that replaces the background-image set in the shadow-dom with a version specific to arc-green so this will be forward-compatible when Chrome decides to fix this in the future by using currentColor or similar.

@silverwind
Copy link
Member Author

Decided to revert to inversion again as it seems somewhat popular around the web so if Chromium authors decided to break this, this method may be the one that survives longer.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2021
@lafriks lafriks merged commit 21465a2 into go-gitea:master May 4, 2021
@silverwind silverwind deleted the webkit-calendar-icon branch May 4, 2021 14:00
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants