Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare tag dropdown to releases page #15695

Merged
merged 5 commits into from
May 3, 2021

Conversation

jtran
Copy link
Contributor

@jtran jtran commented May 1, 2021

Closes #11743.

Beside each release on the releases page, there's now a compare dropdown listing all tags. When a tag is selected, it goes to the compare page comparing the selected tag with the release's tag.

Screen Shot 2021-05-01 at 2 39 54 PM

@jtran jtran mentioned this pull request May 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #15695 (006efdf) into master (5c5cfd6) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15695      +/-   ##
==========================================
+ Coverage   43.89%   43.90%   +0.01%     
==========================================
  Files         678      678              
  Lines       81868    81877       +9     
==========================================
+ Hits        35933    35950      +17     
+ Misses      40086    40073      -13     
- Partials     5849     5854       +5     
Impacted Files Coverage Δ
routers/repo/release.go 24.39% <66.66%> (+1.19%) ⬆️
modules/queue/unique_queue_disk_channel.go 53.73% <0.00%> (-1.50%) ⬇️
modules/queue/workerpool.go 51.64% <0.00%> (-1.10%) ⬇️
services/pull/pull.go 43.47% <0.00%> (-0.46%) ⬇️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
services/pull/check.go 28.76% <0.00%> (+2.73%) ⬆️
modules/notification/mail/mail.go 41.83% <0.00%> (+3.06%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5cfd6...006efdf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2021
@techknowlogick techknowlogick added this to the 1.15.0 milestone May 1, 2021
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels May 1, 2021
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2021
@techknowlogick techknowlogick merged commit 5e047b9 into go-gitea:master May 3, 2021
@jtran jtran deleted the jt/release-tag-compare branch May 3, 2021 18:27
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag comparison
6 participants