Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cron job to delete old actions from database #15688

Merged
merged 3 commits into from
May 1, 2021

Conversation

a1012112796
Copy link
Member

that's a way to save database storage space.

that's a way to save database storage space.

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 1, 2021
@zeripath
Copy link
Contributor

zeripath commented May 1, 2021

TBH I think we're getting to the point quickly whereby we just need to allow people to run arbitrary SQL etc. as a cron task.

@6543
Copy link
Member

6543 commented May 1, 2021

@zeripath they can do this right now by a linux cron task and some scripts ...!

Windows has something similar too, for mac i dont know

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #15688 (9fa833f) into master (ca0460b) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15688      +/-   ##
==========================================
+ Coverage   43.90%   43.92%   +0.01%     
==========================================
  Files         678      678              
  Lines       81809    81827      +18     
==========================================
+ Hits        35921    35939      +18     
+ Misses      40041    40036       -5     
- Partials     5847     5852       +5     
Impacted Files Coverage Δ
models/action.go 47.12% <0.00%> (-1.40%) ⬇️
modules/cron/tasks_extended.go 69.44% <69.23%> (-0.03%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.76% <0.00%> (+2.73%) ⬆️
modules/notification/mail/mail.go 41.83% <0.00%> (+3.06%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0460b...9fa833f. Read the comment docs.

@6543 6543 added this to the 1.15.0 milestone May 1, 2021
@6543 6543 merged commit ae6d786 into go-gitea:master May 1, 2021
@a1012112796 a1012112796 deleted the clear_old_actions branch May 1, 2021 15:03
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants