Turn RepoRef and RepoAssignment back into func(*Context) #15372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Apr 9, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 9, 2021
) Backport go-gitea#15372 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
Apr 9, 2021
GiteaBot
added
lgtm/done
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
Apr 10, 2021
…5377) Backport #15372 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 28, 2021
There was a mistake in go-gitea#15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this pull request
May 5, 2021
…ons (#15653) There was a mistake in #15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 6, 2021
…ons (go-gitea#15653) Backport go-gitea#15653 There was a mistake in go-gitea#15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As revealed on Discord the Wrap PR has revealed the RepoRef and RepoAssignment aren't using next properly.
As both of these function just use Context we should just turn them back to
func(*Context)functions.Signed-off-by: Andrew Thornton [email protected]