Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add well-known config for OIDC #15355

Merged
merged 18 commits into from
Apr 16, 2021
Merged

add well-known config for OIDC #15355

merged 18 commits into from
Apr 16, 2021

Conversation

techknowlogick
Copy link
Member

No description provided.

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Apr 8, 2021
@techknowlogick techknowlogick added this to the 1.15.0 milestone Apr 8, 2021
@techknowlogick techknowlogick mentioned this pull request Apr 8, 2021
Closed
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2021
@silverwind
Copy link
Member

silverwind commented Apr 9, 2021 •
edited
Loading

The template file is tab-indented but I think we generally space-indent json templates. Could you convert and add an entry to .editoconfig for it, like was done here?

https://github.com/go-gitea/gitea/pull/15289/files#diff-0947e2727d6bad8cd0ac4122f5314bb5b04e337393075bc4b5ef143b17fcbd5b

Maybe we should move json templates to templates/json and match that directory.

@techknowlogick
Copy link
Member Author

@silverwind updated per your feedback. Thanks :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2021
@6543 6543 added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Apr 15, 2021
@techknowlogick techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Apr 16, 2021
@techknowlogick techknowlogick merged commit 024ef39 into go-gitea:master Apr 16, 2021
@techknowlogick techknowlogick deleted the oidc-wellknown branch April 16, 2021 02:32
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @silverwind @zeripath @6543 @GiteaBot @lunny