Fix wrong user returned in API #15139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Closed
4 tasks
6543
added
modifies/api
6543
reviewed
Mar 24, 2021
GiteaBot
added
lgtm/need 2
6543
approved these changes
Mar 24, 2021
GiteaBot
added
lgtm/need 1
|
thanks for the pull :) @sotho - finished it for you |
zeripath
changed the title
GiteaBot
added
lgtm/done
|
🚀 |
|
@sotho pleace backport ... if you dont know just ask :) |
sotho
added a commit
to sotho/gitea
that referenced
this pull request
Mar 25, 2021
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
sotho
added a commit
to sotho/gitea
that referenced
this pull request
Mar 25, 2021
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
|
Thanks. I cherry-picked the commit and opened two pull requests: for 1.13 and 1.14. |
|
Hmm. I tried it out, but I think the change you added is not correct. The struct is misleading: the "Reviewer" should be "Commenter" or "Poster", something like: |
This was referenced Mar 25, 2021
|
Damn I think @sotho is right here. it should be reviewID |
|
-> #15164 and after that adjust backports + merge |
6543
added a commit
that referenced
this pull request
Mar 26, 2021
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Fix wrong user returned in API (#15139) The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments returns always the reviewer, but should return the poster. Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]> * rm regression Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
close #15127