-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add dashboard milestone search and repo milestone search by name. #14866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
noerw
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Mar 3, 2021
zeripath
reviewed
Mar 3, 2021
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 3, 2021
zeripath
reviewed
Mar 3, 2021
zeripath
reviewed
Mar 3, 2021
you need to run go fmt on these files too. |
zeripath
approved these changes
Mar 6, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 6, 2021
noerw
approved these changes
Mar 8, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #14866 +/- ##
==========================================
- Coverage 42.21% 42.11% -0.10%
==========================================
Files 767 774 +7
Lines 81624 83045 +1421
==========================================
+ Hits 34458 34977 +519
- Misses 41531 42385 +854
- Partials 5635 5683 +48
Continue to review full report at Codecov.
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for issue 13845:
Two features merged to one PR.
Origin PR:
#14806
Issue link:
#13845
close #13845