Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Description in new/ edit Project template #14429

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Improve Description in new/ edit Project template #14429

merged 3 commits into from
Jan 23, 2021

Conversation

delvh
Copy link
Member

@delvh delvh commented Jan 22, 2021

Previously, non-descriptive text was displayed where a user is prompted to add a project description.
That has been updated with a more descriptive text.

Fixes #14358

@codecov-io
Copy link

codecov-io commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #14429 (9c0f548) into master (91e59a6) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14429      +/-   ##
==========================================
+ Coverage   41.76%   41.79%   +0.02%     
==========================================
  Files         748      748              
  Lines       80103    80103              
==========================================
+ Hits        33458    33476      +18     
+ Misses      41123    41109      -14     
+ Partials     5522     5518       -4
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (-8.00%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/repo_list.go 77.87% <0.00%> (-0.89%) ⬇️
services/pull/pull.go 42.15% <0.00%> (-0.50%) ⬇️
models/error.go 38.98% <0.00%> (ø)
models/issue_comment.go 52.41% <0.00%> (+0.14%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
services/mirror/mirror.go 16.66% <0.00%> (+1.09%) ⬆️
modules/git/batch_reader_nogogit.go 46.26% <0.00%> (+1.49%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e59a6...9c0f548. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 22, 2021
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Jan 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2021
@delvh
Copy link
Member Author

delvh commented Jan 23, 2021

Can someone with merge permissions merge this branch please?
Unless there are yet undiscovered concerns, of course…

@6543 6543 merged commit 9872b8d into go-gitea:master Jan 23, 2021
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
c599356 
* master: (358 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into empty_pr
7863e53 
* master: (542 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
@delvh delvh mentioned this pull request Jan 29, 2021
Closed
2 tasks
6543 pushed a commit that referenced this pull request Jan 29, 2021
@delvh
Fix missing locale bug introduced by #14429 (#14513)
aec8029 
Fixes #14512
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Add prompt text for description when creating/ editing Projects
5 participants
@delvh @codecov-io @lunny @6543 @GiteaBot