Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Ghost comment mitigation Settings #14392

Merged
merged 12 commits into from
Jan 22, 2021
Merged

Enhance Ghost comment mitigation Settings #14392

merged 12 commits into from
Jan 22, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 18, 2021 •
edited
Loading

a refactor ... and follow up of #14349

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 18, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 18, 2021
@6543 6543 changed the title Enhance Ghost comment mitigation Enhance Ghost comment mitigation Settings Jan 18, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2021
@6543 6543 added the type/enhancement An improvement of existing functionality label Jan 18, 2021
@6543
Copy link
Member Author

6543 commented Jan 19, 2021

@CirnoT @lafriks Disabled by Default

@codecov-io
Copy link

Codecov Report

Merging #14392 (83f9c2d) into master (0c0445c) will decrease coverage by 0.05%.
The diff coverage is 32.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14392      +/-   ##
==========================================
- Coverage   41.84%   41.78%   -0.06%     
==========================================
  Files         744      744              
  Lines       79779    79797      +18     
==========================================
- Hits        33387    33347      -40     
- Misses      40874    40960      +86     
+ Partials     5518     5490      -28
Impacted Files Coverage Δ
models/admin.go 60.31% <0.00%> (ø)
routers/user/setting/account.go 24.74% <0.00%> (ø)
services/comments/comments.go 69.23% <0.00%> (ø)
models/user.go 53.00% <8.69%> (-0.63%) ⬇️
models/issue_comment.go 45.24% <50.00%> (-7.05%) ⬇️
models/issue_assignees.go 74.19% <100.00%> (ø)
models/issue_reaction.go 82.58% <100.00%> (+0.19%) ⬆️
modules/setting/service.go 82.14% <100.00%> (ø)
modules/notification/mail/mail.go 33.33% <0.00%> (-5.56%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0445c...83f9c2d. Read the comment docs.

zeripath
zeripath reviewed Jan 20, 2021
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved
services/comments/comments.go Outdated Show resolved Hide resolved
@6543 6543 force-pushed the enhance_ghost-comment-mitigation branch from 404080b to 9ffbdc2 Compare January 21, 2021 21:05
zeripath
zeripath approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

models/issue_comment.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2021
@techknowlogick techknowlogick merged commit a0e424d into go-gitea:master Jan 22, 2021
@techknowlogick
Copy link
Member

Please send partial backport :)

@6543 6543 deleted the enhance_ghost-comment-mitigation branch January 22, 2021 03:45
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 22, 2021
@6543
Enhance Ghost comment mitigation Settings (go-gitea#14392)
9a19979 
* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* Resolve Fixme & fix potential deadlock
@6543 6543 mentioned this pull request Jan 22, 2021
Merged
@6543
Copy link
Member Author

6543 commented Jan 22, 2021

@techknowlogick Backport -> #14425

@6543 6543 added the backport/done All backports for this PR have been created label Jan 22, 2021
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 22, 2021
@6543 @zeripath
Enhance Ghost comment mitigation Settings (go-gitea#14392)
3286397 
* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* nits

* Use time.Duration as other time settings have

* docs

* Resolve Fixme & fix potential deadlock

* Disabled by Default

* Update Config Value Description

* switch args

* Update models/issue_comment.go

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
lunny pushed a commit that referenced this pull request Jan 23, 2021
@6543
[Backport] Fix Deadlock & Delete affected reactions on comment deleti…
4d2a6c4 
…on (#14392) (#14425)

* Enhance Ghost comment mitigation Settings (#14392)

* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* Resolve Fixme & fix potential deadlock

* rm refactor

* make diff eaven less
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Feb 26, 2021
@6543 @zeripath @ashimokawa
Enhance Ghost comment mitigation Settings (go-gitea#14392)
8156057 
* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* nits

* Use time.Duration as other time settings have

* docs

* Resolve Fixme & fix potential deadlock

* Disabled by Default

* Update Config Value Description

* switch args

* Update models/issue_comment.go

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Mar 10, 2021
@6543 @zeripath @ashimokawa
Enhance Ghost comment mitigation Settings (go-gitea#14392)
b473252 
* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* nits

* Use time.Duration as other time settings have

* docs

* Resolve Fixme & fix potential deadlock

* Disabled by Default

* Update Config Value Description

* switch args

* Update models/issue_comment.go

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT left review comments

@lafriks lafriks lafriks left review comments

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-io @techknowlogick @lafriks @CirnoT @zeripath @GiteaBot