Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ServerError provided by Context #14333

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 14, 2021

ctx.InternalServerError(err) could not be used with context.Context because it's a method of macaron.Context or context.APIContext.

Bugs introduced in #14243, #10967, #9784, #8346

@lunny lunny added the type/bug label Jan 14, 2021
@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@edbc5c8). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14333   +/-   ##
=========================================
  Coverage          ?   41.86%           
=========================================
  Files             ?      744           
  Lines             ?    79638           
  Branches          ?        0           
=========================================
  Hits              ?    33342           
  Misses            ?    40811           
  Partials          ?     5485           
Impacted Files Coverage Δ
routers/admin/users.go 38.84% <0.00%> (ø)
routers/repo/issue.go 38.17% <0.00%> (ø)
routers/repo/projects.go 13.42% <0.00%> (ø)
routers/repo/pull.go 31.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbc5c8...2fb252f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2021
@6543 6543 changed the title Fix bug Use ServerError provided by Context Jan 14, 2021
@6543 6543 merged commit 60a3297 into go-gitea:master Jan 14, 2021
@lunny lunny deleted the lunny/fix_servererror branch January 15, 2021 03:28
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 15, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 15, 2021
lunny added a commit to lunny/gitea that referenced this pull request Jan 15, 2021
... instead of InternalServerError by macaron
lunny added a commit that referenced this pull request Jan 15, 2021
... instead of InternalServerError by macaron
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants