[docs] Enhance container selection in docker dump #14292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the previous query was, that it sometimes selected multiple containers, which make the command file with a hard to understand message.
openscript
changed the title
Codecov Report
@@ Coverage Diff @@
## master #14292 +/- ##
=========================================
Coverage ? 41.84%
=========================================
Files ? 744
Lines ? 79727
Branches ? 0
=========================================
Hits ? 33364
Misses ? 40854
Partials ? 5509 Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
type/docs
6543
reviewed
Jan 17, 2021
Co-authored-by: 6543 <[email protected]>
6543
approved these changes
Jan 17, 2021
GiteaBot
added
lgtm/need 1
zeripath
reviewed
Jan 17, 2021
|
@openscript Any update? |
|
@lunny I'll check it today and give some feedback :) |
|
@lunny I can verify that it works without the quotes. This is I usually do my backups:
Maybe this section in the documentation can be enhanced further. When no file name for the dump is specified, a timestamp will be used. So you need to go into the container to find the actual file name. |
|
Without quotes it is shell dependent. Bash works fine but zsh definitely will not. |
Co-authored-by: delvh <[email protected]>
|
I think @delvh 's suggestion is pretty good. So, approve and move on? |
6543
approved these changes
Mar 9, 2022
delvh
approved these changes
Mar 9, 2022
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Mar 22, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 22, 2022
* giteaofficial/main: Fix the bug: deploy key with write access can not push (go-gitea#19010) Renamed ctx.User to ctx.Doer. (go-gitea#19161) [docs] Enhance container selection in docker dump (go-gitea#14292) Cleanup protected branches when deleting users & teams (go-gitea#19158) Reorder issue templates and automatically add labels (go-gitea#18875) Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Enhance container selection in docker dump The problem with the previous query was, that it sometimes selected multiple containers, which make the command file with a hard to understand message. Now, use '^...$' to make sure a regex full match.
delvh
added
topic/distribution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the previous query was, that it sometimes selected multiple containers, which make the command respond with a hard to understand error message.
With this regular expression only the container is selected with the exact name.