Remove obsolete change of email on profile page #13341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change email on the account profile page is out-of-date and unnecessary. Changing email should be done using the account page. Fix go-gitea#13336 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
Oct 28, 2020
GiteaBot
added
the
lgtm/need 1
|
Another option would be for this page to replicate the options on the account page. |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
silverwind
approved these changes
Oct 28, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Oct 28, 2020
|
🚀 |
Codecov Report
@@ Coverage Diff @@
## master #13341 +/- ##
==========================================
- Coverage 42.12% 42.09% -0.03%
==========================================
Files 689 689
Lines 75846 75845 -1
==========================================
- Hits 31949 31930 -19
- Misses 38664 38679 +15
- Partials 5233 5236 +3
Continue to review full report at Codecov.
|
techknowlogick
pushed a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
* Remove obsolete change of email on profile page The change email on the account profile page is out-of-date and unnecessary. Changing email should be done using the account page. Fix go-gitea#13336 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
* Remove obsolete change of email on profile page The change email on the account profile page is out-of-date and unnecessary. Changing email should be done using the account page. Fix go-gitea#13336 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
added a commit
that referenced
this pull request
Oct 29, 2020
* Remove obsolete change of email on profile page The change email on the account profile page is out-of-date and unnecessary. Changing email should be done using the account page. Fix #13336 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>
zeripath
added a commit
that referenced
this pull request
Oct 29, 2020
* Remove obsolete change of email on profile page The change email on the account profile page is out-of-date and unnecessary. Changing email should be done using the account page. Fix #13336 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change email on the account profile page is out-of-date
and unnecessary.
Changing email should be done using the account page.
Fix #13336
Signed-off-by: Andrew Thornton [email protected]