Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: GetReleaseByID return 404 if not found #12933

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 24, 2020

as title

@6543 6543 added modifies/api This PR adds API routes or modifies them type/bug labels Sep 24, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 24, 2020
@6543 6543 added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #12933 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12933      +/-   ##
==========================================
- Coverage   43.09%   43.08%   -0.01%     
==========================================
  Files         658      658              
  Lines       72455    72456       +1     
==========================================
- Hits        31226    31221       -5     
- Misses      36175    36179       +4     
- Partials     5054     5056       +2     
Impacted Files Coverage Δ
routers/api/v1/repo/release.go 33.60% <33.33%> (+0.54%) ⬆️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba20dd7...d16e430. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2020
@techknowlogick techknowlogick merged commit efebb82 into go-gitea:master Sep 24, 2020
@6543 6543 deleted the api-release-better-error-handling branch September 25, 2020 16:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants