-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CheckUnitUser logic #12854
Simplify CheckUnitUser logic #12854
Conversation
if check one user's unit in different repos, it's not necessary to get user data every time. Signed-off-by: a1012112796 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12854 +/- ##
==========================================
- Coverage 43.11% 43.08% -0.03%
==========================================
Files 655 655
Lines 72328 72329 +1
==========================================
- Hits 31186 31165 -21
- Misses 36094 36111 +17
- Partials 5048 5053 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there are lots more improvements possible here.
if check one user's unit in different repos, it's not necessary to get user data every time.