Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set language via AJAX #12785

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Set language via AJAX #12785

merged 3 commits into from
Sep 10, 2020

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Sep 9, 2020

Fix #10725

Edit: putting this in 1.13 milestone as gitea.com's logs are full of search engines using ?Lang=lang

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Sep 9, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 9, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #12785 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12785      +/-   ##
==========================================
- Coverage   43.26%   43.22%   -0.04%     
==========================================
  Files         650      650              
  Lines       72048    72048              
==========================================
- Hits        31172    31146      -26     
- Misses      35837    35856      +19     
- Partials     5039     5046       +7     
Impacted Files Coverage Δ
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-1.16%) ⬇️
modules/git/repo.go 49.74% <0.00%> (-1.02%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc410c...f31431b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 9, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@lunny lunny merged commit 33ac0cc into go-gitea:master Sep 10, 2020
@techknowlogick techknowlogick deleted the fix-10725 branch September 10, 2020 01:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use POST to change user selected language
5 participants