Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix comment broken issue ref dependence (#12651) #12692

Merged
merged 4 commits into from
Sep 3, 2020
Merged

[Backport] Fix comment broken issue ref dependence (#12651) #12692

merged 4 commits into from
Sep 3, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 2, 2020

Backport of #12651

@6543 6543 mentioned this pull request Sep 2, 2020
Merged
@6543
Copy link
Member Author

6543 commented Sep 2, 2020

@techknowlogick can you tag 1.12.4?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 2, 2020
@techknowlogick techknowlogick added this to the 1.12.4 milestone Sep 2, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2020
@6543
Copy link
Member Author

6543 commented Sep 3, 2020

ready to 🚀

@lunny lunny merged commit 0fa538e into go-gitea:release/v1.12 Sep 3, 2020
@6543 6543 deleted the backport_fix-comment-broken-issue-ref-dependence_12651 branch September 3, 2020 10:37
@6543 6543 mentioned this pull request Sep 4, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.4
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @techknowlogick @zeripath @lunny @GiteaBot