Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Cache with ini tag #12605

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Mark Cache with ini tag #12605

merged 1 commit into from
Aug 25, 2020

Conversation

jolheiser
Copy link
Member

Fixes #12587

(Note that this doesn't usually show up in admin UI with memory cache, I fudged the template to show it for an example)

cache

Signed-off-by: jolheiser <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 25, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12605 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12605      +/-   ##
==========================================
- Coverage   43.41%   43.40%   -0.01%     
==========================================
  Files         645      645              
  Lines       71288    71288              
==========================================
- Hits        30947    30942       -5     
- Misses      35327    35333       +6     
+ Partials     5014     5013       -1     
Impacted Files Coverage Δ
modules/setting/cache.go 52.38% <ø> (ø)
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
routers/repo/view.go 37.33% <0.00%> (-0.65%) ⬇️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4db04...fee5956. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 25, 2020
@lafriks lafriks merged commit b611ae1 into go-gitea:master Aug 25, 2020
@lafriks
Copy link
Member

lafriks commented Aug 25, 2020

Please send backport

jolheiser added a commit to jolheiser/gitea that referenced this pull request Aug 26, 2020
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Aug 26, 2020
techknowlogick pushed a commit that referenced this pull request Aug 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea apparently not respecting set cache TTL
5 participants