Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge #12538

Closed
wants to merge 1 commit into from
Closed

Fix merge #12538

wants to merge 1 commit into from

Conversation

manuelluis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #12538 into master will decrease coverage by 0.06%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12538      +/-   ##
==========================================
- Coverage   43.55%   43.49%   -0.07%     
==========================================
  Files         642      642              
  Lines       71009    71012       +3     
==========================================
- Hits        30931    30886      -45     
- Misses      35076    35118      +42     
- Partials     5002     5008       +6     
Impacted Files Coverage Δ
services/pull/merge.go 49.72% <25.00%> (-0.42%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/notification/mail/mail.go 32.50% <0.00%> (-3.75%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/pull/check.go 48.46% <0.00%> (-1.54%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5440fc...32b3b35. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 20, 2020
@lunny lunny added the type/bug label Aug 20, 2020
@zeripath
Copy link
Contributor

#12535 fixes this

@zeripath zeripath closed this Aug 20, 2020
@zeripath
Copy link
Contributor

Thanks @manuelluis for your hard work we've already merged a slightly different fix #12535

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants