Fix incorrect error logging in Stats indexer and OAuth2 #12387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11945 Signed-off-by: Andrew Thornton <[email protected]>
Fix go-gitea#12380 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
techknowlogick
approved these changes
Jul 31, 2020
GiteaBot
added
the
lgtm/need 1
Add the missing character in the error message.
silverwind
approved these changes
Aug 1, 2020
GiteaBot
added
lgtm/done
|
Please send backport |
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Aug 4, 2020
* Fix incorrect logging in oauth2.go Fix go-gitea#11945 Signed-off-by: Andrew Thornton <[email protected]> * Handle ErrAlreadyInQueue in stats indexer Fix go-gitea#12380 Signed-off-by: Andrew Thornton <[email protected]> * Fixes type in error message of indexer Add the missing character in the error message. Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lieven Hollevoet <[email protected]>
techknowlogick
added
the
backport/done
|
I've just sent the backport in #12387 |
lunny
pushed a commit
that referenced
this pull request
Aug 4, 2020
) * Fix incorrect logging in oauth2.go Fix #11945 Signed-off-by: Andrew Thornton <[email protected]> * Handle ErrAlreadyInQueue in stats indexer Fix #12380 Signed-off-by: Andrew Thornton <[email protected]> * Fixes type in error message of indexer Add the missing character in the error message. Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lieven Hollevoet <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lieven Hollevoet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two cases of bad logging:
Fix #12380
Fix #11945
Signed-off-by: Andrew Thornton [email protected]