-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong log when push to a new branch #1220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the comment
@@ -360,7 +360,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit) err | |||
|
|||
issue, err := GetIssueByRef(ref) | |||
if err != nil { | |||
if IsErrIssueNotExist(err) { | |||
if IsErrIssueNotExist(err) || err == errMissingIssueNumber { | |||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if GetIssueByRef should just return an ErrIssueNotExist even when an issue number is missing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check could we do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetIssueByRef
will return many kinds of error besides ErrIssueNotExist
and errMissingIssueNumber
. Don't know how to fix this.
Does the LGTM bot not look into reviews ? |
@strk L-G-T-M bot doesn't look into review comments. :( |
LGTM except for @strk's comment |
fix #1111