Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments webhook panic #12046

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Fix comments webhook panic #12046

merged 3 commits into from
Jun 25, 2020

Conversation

cornelk
Copy link
Contributor

@cornelk cornelk commented Jun 24, 2020

Closes #11940

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2020
@lunny lunny added this to the 1.13.0 milestone Jun 25, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit ebc35f2 into go-gitea:master Jun 25, 2020
@techknowlogick
Copy link
Member

@cornelk thank you for the PR :) would you be able to send this as a backport to the release/v1.12 branch?

@cornelk
Copy link
Contributor Author

cornelk commented Jun 25, 2020

@techknowlogick yes I will send a backport later

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 25, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Fix webhook comment handling type cast panic

* Handle HookIssueReviewed action in webhook

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a comment in review panics
5 participants