Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: change commentTag style #11668

Merged
merged 11 commits into from
Sep 10, 2020
Merged

ui: change commentTag style #11668

merged 11 commits into from
Sep 10, 2020

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented May 29, 2020 •
edited
Loading

  • Add comment tag in first comment (issue content)
  • Show CommentTagPoster in other way

view:
image

fix #11592

@a1012112796
ui: change commentTag style
c3ec572 
* Add comment tag in first comment (issue content)
* Show CommentTagPoster in other way

Signed-off-by: a1012112796 <[email protected]>
lafriks
lafriks reviewed May 29, 2020
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2020
lunny
lunny requested changes May 30, 2020
View reviewed changes
models/issue_comment.go Outdated Show resolved Hide resolved
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jun 10, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 10, 2020
@CirnoT
Copy link
Contributor

CirnoT commented Jun 14, 2020

Related #11592

@stale
Copy link

stale bot commented Aug 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 17, 2020
@a1012112796
Copy link
Member Author

ping :)

@stale stale bot removed the issue/stale label Aug 17, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 17, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #11668 into master will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11668   +/-   ##
=======================================
  Coverage   43.20%   43.21%           
=======================================
  Files         650      650           
  Lines       72099    72101    +2     
=======================================
+ Hits        31153    31160    +7     
+ Misses      35900    35893    -7     
- Partials     5046     5048    +2
Impacted Files Coverage Δ
models/issue.go 56.46% <ø> (ø)
routers/repo/issue.go 37.13% <25.00%> (+0.01%) ⬆️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
modules/log/event.go 58.49% <0.00%> (+0.94%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b10da2...c3c2d3c. Read the comment docs.

@techknowlogick techknowlogick merged commit 4f8dad3 into go-gitea:master Sep 10, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Comment should have multiple tags
7 participants
@a1012112796 @CirnoT @codecov-commenter @lunny @techknowlogick @lafriks @GiteaBot