Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return json on 500 error from API (#11574) #11660

Merged
merged 1 commit into from
May 28, 2020
Merged

Return json on 500 error from API (#11574) #11660

merged 1 commit into from
May 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 28, 2020

Backport #11574

  • add API specific InternalServerError()

  • InternalServerError

@6543 @zeripath
Return json on 500 error from API (go-gitea#11574)
0b2c110 
* add API specific InternalServerError()

Co-authored-by: zeripath <[email protected]>

* return 500 error msg only if not Production mode

* Revert "return 500 error msg only if not Production mode"

This reverts commit 8467b2c.

* InternalServerError

Co-authored-by: zeripath <[email protected]>
@zeripath zeripath added modifies/api This PR adds API routes or modifies them type/bug labels May 28, 2020
@zeripath zeripath added this to the 1.11.6 milestone May 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@zeripath zeripath merged commit ed64607 into go-gitea:release/v1.11 May 28, 2020
@6543 6543 deleted the backport-11574_v111_API-JSON branch May 28, 2020 18:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.11.6
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @jolheiser @GiteaBot